salesagility / SuiteCRM

SuiteCRM - Open source CRM for the world
https://www.suitecrm.com
GNU Affero General Public License v3.0
4.55k stars 2.1k forks source link

Version 7.3.2 : case updates threaded issue #2015

Closed xujianningkp closed 7 years ago

xujianningkp commented 8 years ago

Issue

since updated to Version 7.3.2 Sugar Version 6.5.20 (Build 1001), I'm unable to update case under "Case Updates Threaded" section. once I click save, it will pops up a window says "Performing Task, Once moment please..." this window will stays there forever until I close it manually, and it creates case update with value "undefined". In addition, I will see this case update "undefined" when creating a new case as well. Please see attached screenshot for more detail. I tried to reboot the virtual machines and also the Apache server, but no luck. Any suggest to fix this issue will be greatly appreciated. Thank you.

After save is clicked: image

When creating new case: image

Your Environment

* SuiteCRM Version used: Version 7.3.2 Sugar Version 6.5.20 (Build 1001) * Browser name and version: Google Chrome Version 52.0.2743.116 m (64-bit) * Operating System and version (e.g Ubuntu 16.04): CentOS 7 x64

shogunpol commented 8 years ago

This issue appears when you sync the detail view and edit view using studio. May have something with attach form field. Thanks for raising this issue. We work on solve this problem.

xujianningkp commented 8 years ago

Thank you shogunpol. do you have any updates of this issue?

shogunpol commented 8 years ago

There is work around for this, and this is by removing internal update, and update text fields, from the detail view in studio. The problem we seen here is this two fields, are duplicated on form, and this is whats causing the problem. We are still currently work on this issue, we let you know as soon as we solve the problem.

opensourcecrm commented 8 years ago

Hi Shogunpol if you could check this Issue with Sending an Email from regular module of email as well as quickemail activity. #2115 and suggestion some fix it would be helpful

shogunpol commented 7 years ago

The issue has been retested on newest version SuiteCRM(7.7.8), and not appear, @xujianningkp , this issue will be closed, if it still an issue for you it can be reopened.

Glen206 commented 7 years ago

After being updated that this thread was closed and I had updated to 7.7.8. I tried our cases module and I still do not show any thread updates and in addition now when I click on the save button the dialogue box pops up but it hangs and and I cannot close it.

In chrome these are the errors that appear.

index.php?module=Cases&action=DetailView&record=b72b02e3-2e5c-376c-8603-57d7004f73db:1693 Refused to set unsafe header "Content-length" caseUpdates @ index.php?module=Cases&action=DetailView&record=b72b02e3-2e5c-376c-8603-57d7004f73db:1693 index.php?module=Cases&action=DetailView&record=b72b02e3-2e5c-376c-8603-57d7004f73db:1694 Refused to set unsafe header "Connection" caseUpdates @ index.php?module=Cases&action=DetailView&record=b72b02e3-2e5c-376c-8603-57d7004f73db:1694

shogunpol commented 7 years ago

@Glen206 , can i ask you to give me details about your environment and if it issue appear in fresh install or updated?

Glen206 commented 7 years ago

@shogunpol, This is on an updated SuiteCRM, I don't recall the base version we started with but it was at least 6.5.20. it was not a Sugar Conversion

SuiteCRM 7.7.8 L A MySQL, PHP 7

Let me know if you need any other information. here is video of the behavior: http://www.screencast.com/t/o979WzgvN96

pgorod commented 7 years ago

@Glen206 did you ever look at the information I left on your bug, #2237?

I found a root cause and a solution. I'm not sure your case is exactly like mine, but it's worth trying that fix.

It's also quite difficult for SalesAgility to help you with this, as it doesn't show on new installations, this is a problem of left-overs in the custom directory after upgrades...

urdhvatech commented 6 years ago

The problem still persists in SuiteCRM version 7.10.4. The actual reason why "undefined" appears is because of a code issue.

Step to generate: If you have 1 or more case thread updates we have multiple "update_text" as spans and one for the actual textarea of "Updates - Text".

So the code at line no 96 of file modules/AOP_Case_Updates/Case_Updates.php var update_data = encodeURIComponent(document.getElementById('update_text').value); Tries to get the value of the span id "update_text" instead of the textarea.

Proposed Solution:

Try to get the value of the textarea. var update_data = encodeURIComponent($("textarea#update_text").val());

pgorod commented 6 years ago

@urdhvatech that's a nice find. Can you make a PR with this fix?

pgorod commented 6 years ago

@urdhvatech on second thought... I can't reproduce this on my 7.10.6.

I simply tried a Case with 2 or 3 threaded updates. Are any other steps needed to re-create the bug?

urdhvatech commented 6 years ago

Hi @pgorod I got the reason why it happens, It is the "Updates - Text" field which usually is only on editview. But when someone syncs it to detailview the field will be added on DetailView. The detailview page will have 2 id with same name "update_text". 1 for <span class="sugar_field" id="update_text"></span> and 2nd for <textarea id="update_text" name="update_text" cols="80" rows="4"></textarea> So the problem can come to someone who syncs the view. So on safer side, it would be good to have the proposed solution var update_data = encodeURIComponent($("textarea#update_text").val()); I will try to get the PR soon as I find the time.

ghost commented 1 year ago

Hello All First time post...

I realize this is an old thread but I am chasing a similar/same problem Suitecrm 8.2.2 Ubuntu 20.4 Php 7.4 I can see the Case Updates text is being saved to the database but it is not displaying in the that field If I click the insights button in the top right of a Case I can see those updates and create new updates from that view. image

I've gone through a few threads on this form but can't pin it down or it is above my knowledge. I tried un-sycing the detail and edit views and removing the fields " Case Updates text" and "Internal Update" from the detail but no luck. I have done some customization of this modle by just adding a few fields and edited some status dropdowns

Any ideas would be greatly appreciated.

pgorod commented 1 year ago

This code is simply different in v8, there is no point on handling this in the current thread.

Have you tried this in the online demo? That way you could see if that problem is only in your system. https://suite8demo.suiteondemand.com/

And then if necessary open a new issue on the v8 repository. https://github.com/salesagility/SuiteCRM-Core/issues/

ghost commented 1 year ago

I’ll do as suggested Thanks!

On Sat, 7 Jan 2023 at 9:46 pm pgorod @.***> wrote:

This code is simply different in v8, there is no point on handling this in the current thread.

Have you tried this in the online demo? That way you could see if that problem is only in your system. https://suite8demo.suiteondemand.com/

And then if necessary open a new issue on the v8 repository. https://github.com/salesagility/SuiteCRM-Core/issues/

— Reply to this email directly, view it on GitHub https://github.com/salesagility/SuiteCRM/issues/2015#issuecomment-1374436421, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5DL7OJMOTHQTBLZTFQACMLWRFCPNANCNFSM4CNJB6JA . You are receiving this because you commented.Message ID: @.***>

-- Scott Vinnicombe Electronics Wiz m: 0414766824 e: @.***

[image: Dante Certified] https://au.linkedin.com/in/scottvinnicombe https://facebook.com/scottvinnicombephotography https://instagram.com/scottvinnicombephotography