Fix dupe_check for Bazel 7

salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar

BSD 3-Clause "New" or "Revised" License

229 stars 49 forks source link

Fix dupe_check for Bazel 7 #190

Closed hjellek closed 9 months ago

hjellek commented 9 months ago

Fixes #180

As far as I can tell the problem comes from https://github.com/bazelbuild/bazel/issues/16303

Depending on the executable directly solves this issue, as well as being easier to understand (for me, at least)

Depending on rules_python directly might actually not be necessary but from what I've read it's the best practice as there seems to be ongoing work on moving the python rules out from Bazel itself.

Suggestions are welcome!

hjellek commented 9 months ago

Realized now that this change requires Bazel 6 or newer due to the rules_python package.

@plaird any thoughts on this? Is it a requirement to support Bazel 5 for rules_spring?

plaird commented 9 months ago

We can go with Bazel 6. Users of older Bazels can refer to an older commit.