salesforce / rules_spring

Bazel rule for building Spring Boot apps as a deployable jar
BSD 3-Clause "New" or "Revised" License
229 stars 49 forks source link

#205 Fix non-determinism in build-data.properties file #206

Closed jpgxs closed 1 month ago

jpgxs commented 1 month ago

Invoke singlejar with a relative path to the output JAR, preventing the build-data.properties file from containing the absolute path.

Fixes: #205

salesforce-cla[bot] commented 1 month ago

Thanks for the contribution! Before we can merge this, we need @jgriffiths-od to sign the Salesforce Inc. Contributor License Agreement.

salesforce-cla[bot] commented 1 month ago

Thanks for the contribution! Before we can merge this, we need @jpgxs to sign the Salesforce Inc. Contributor License Agreement.

plaird commented 1 month ago

I will test within Salesforce (we have a large number of springboot use cases), and cut an official release soon.