search

salrashid123 / terraform-provider-http-full

Terraform HTTP provider with mTLS and JSON POST support
Apache License 2.0
13 stars 4 forks source link

Support retry block #16

Open Avital103 opened 1 year ago

Avital103 commented 1 year ago

Hi

I'm pleased to inform you that starting from version v3.3.0, a retry block has been introduced and is now available for use.

With this new feature, one has the opportunity to utilize the retry functionality.

Would it be feasible to implement this feature within this provider? Thanks ahead

salrashid123 commented 1 year ago

sure, i don't see why not,

it should be just a copy+paste of upstream

https://github.com/hashicorp/terraform-provider-http/blob/main/internal/provider/data_source_http.go#L250-L288

somewhere here

https://github.com/salrashid123/terraform-provider-http-full/blob/main/internal/provider/data_source.go#L253

i'll look at it later today

salrashid123 commented 1 year ago

spoke too soon; its not that simple since i probably now should first upgrade to the new provider framework

it'll take quite a bit more time so hopefully later this week or next

Avital103 commented 1 year ago

That would be amazing! I'm really looking forward to it. Thank you for providing an update. I'll patiently await the upgrade later this week or next. Your efforts are greatly appreciated!

ibarisic05 commented 1 year ago

It is been quite some time there has been activity on this issue, do you have in plan to introduce retry block?

salrashid123 commented 1 year ago

i have to rework the code from scratch but one issue i ran into is how to account for the existing behavior which fails fast and using "github.com/hashicorp/go-retryablehttp" client (vs regular client).