saltstack-formulas / nfs-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Apache License 2.0
18 stars 83 forks source link

fix(null): replace `None` with null in yaml files #36

Closed sticky-note closed 4 years ago

sticky-note commented 4 years ago

PR progress checklist (to be filled in by reviewers)


What type of PR is this?

Primary type

Secondary type

Does this PR introduce a BREAKING CHANGE?

No.

Related issues and/or pull requests

https://github.com/saltstack/salt/issues/43694

Describe the changes you're proposing

replace None with null in yaml files as None is considered as astring "None" by pyYAML

Pillar / config required to test the proposed changes

Debug log showing how the proposed changes work

Documentation checklist

Testing checklist

Additional context

pull-assistant[bot] commented 4 years ago
Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix(null): replace `None` with null in yaml files

Powered by Pull Assistant. Last update 88a3c54 ... 88a3c54. Read the comment docs.

myii commented 4 years ago

Thanks @sticky-note.

saltstack-formulas-travis commented 4 years ago

:tada: This PR is included in version 0.11.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: