search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 232 forks source link

Fix Backward compatibility problem #168

Closed pawelrosada closed 5 years ago

sticky-note commented 5 years ago

Thanks, is this variable is intended to use only with RedHat ? Formulas fails in my side because I run it on a Debian server. After investigation I found this 'enable_php_repo' var is only set for RedHat: https://github.com/saltstack-formulas/php-formula/blob/0c923245e67c31bd51b78595bae57ad066c2a31b/php/ng/installed.jinja#L75 but it used outside this if elsif statement ...

As documented on pillar, there is an 'use_external_repo' and 'external_repo_name' vars. What is different with this new var?

ricariel commented 5 years ago

Same as Issue #169

aboe76 commented 5 years ago

@sticky-note can you test the proposed solution

sticky-note commented 5 years ago

It seems to work but #166 seems to introduce a mistake as it modify behavior for RedHat only ...

ze42 commented 5 years ago

It works here too, properly fixes bug introduced by #166 for non-RedHat.

Fix kinda required for non-RedHat use.

aboe76 commented 5 years ago

merged it.