search

saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 232 forks source link

Provide kitchen tests for php-formula #174

Closed arthurzenika closed 5 years ago

arthurzenika commented 5 years ago

In a number of saltstack-formulas there are kitchen https://kitchen.ci/ tests to test the code and deployment in sandbox VMs. It would be nice to have such tests on php-formula

myii commented 5 years ago

@arthurlogilab Thanks for creating this issue. For any intrepid contributor looking to take up this task, please base the matrix on either the salt-formula or the template-formula. These contain the latest, recommended ways to do this. Both of these will probably be standardised soon -- in that case, the template-formula will be the best source for the configuration required.

@javierbertoli Any further opinions about this?

myii commented 5 years ago

@arthurlogilab The structure has been introduced by @n-rodriguez in #179. It's just a matter of adding InSpec tests now.

n-rodriguez commented 5 years ago

@myii working on it right now. There is a bug in https://github.com/saltstack-formulas/php-formula/blob/master/php/fpm/pools_config.sls#L21

n-rodriguez commented 5 years ago

@myii it would be nice to implement the repo pattern in this formula.

The repo config available in pillars are very specific (centos, ubuntu). The repo pattern would help to configure repos for other distros.

It would also ease testing by setting custom repos in Kitchen. I'm using Debian in production with php-sury and it does support multiple php install. This way I could install multiple versions of Php and test various configurations. What do you think?

n-rodriguez commented 5 years ago

@myii it would be nice to implement the repo pattern in this formula.

ping @myii

myii commented 5 years ago

@n-rodriguez Sounds great, thanks for providing this in #197.

saltstack-formulas-travis commented 5 years ago

:tada: This issue has been resolved in version 1.1.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: