saltstack-formulas / php-formula

http://docs.saltstack.com/en/latest/topics/development/conventions/formulas.html
Other
57 stars 232 forks source link

fix(pillar): fix pillar.get still looking under 'ng' namespace #194

Closed n-rodriguez closed 5 years ago

myii commented 5 years ago

Excellent catch, @n-rodriguez! Much needed after #183, thanks.

saltstack-formulas-travis commented 5 years ago

:tada: This PR is included in version 1.0.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

sticky-note commented 5 years ago

@n-rodriguez @myii Extremely sorry that I've not verified that part each time I made a rebase :'(

sticky-note commented 5 years ago

Can you amend the v1.0.0 to make that clean ?

n-rodriguez commented 5 years ago

tada This PR is included in version 1.0.1 tada

sticky-note commented 5 years ago

Hope that's not a problem to not have a fully functionnal v1.0.0

myii commented 5 years ago

@sticky-note The first release of a new version always has minor issues with it, it's normal. You did a great job, especially with the multiple rebases that had to take place!