feat(composer): make dependencies configurable

alxwr commented 3 years ago

PR progress checklist (to be filled in by reviewers)

[X] Changes to documentation are appropriate (or tick if not required)
[X] Changes to tests are appropriate (or tick if not required)
[ ] Reviews completed

What type of PR is this?

Primary type

[ ] [build] Changes related to the build system
[ ] [chore] Changes to the build process or auxiliary tools and libraries such as documentation generation
[ ] [ci] Changes to the continuous integration configuration
[X] [feat] A new feature
[ ] [fix] A bug fix
[ ] [perf] A code change that improves performance
[ ] [refactor] A code change that neither fixes a bug nor adds a feature
[ ] [revert] A change used to revert a previous commit
[ ] [style] Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc.)

Secondary type

[X] [docs] Documentation changes
[ ] [test] Adding missing or correcting existing tests

Does this PR introduce a `BREAKING CHANGE`?

No.

Related issues and/or pull requests

–

Describe the changes you're proposing

On FreeBSD, when using PHP 7.4, there's no package php74-hash available. When using PHP 7.2, php72-hash must be installed.

Pillar / config required to test the proposed changes

See php:lookup:composer in pillar.example.

Debug log showing how the proposed changes work

–

Documentation checklist

[ ] Updated the README (e.g. Available states).
[X] Updated pillar.example.

Testing checklist

[ ] Included in Kitchen (i.e. under state_top).
[ ] Covered by new/existing tests (e.g. InSpec, Serverspec, etc.).
[ ] Updated the relevant test pillar.

Additional context

myii commented 3 years ago

@alxwr Thanks for the PR and apologies for the delay in getting around to it. I've pushed FreeBSD CI testing on top of your commit, which specifically tests the composer state.

Note that I did test php80 first but there's no php80-json package available.

LGTM, does someone has a FreeBSD to confirm on that platform?

@baby-gnu Done!

Semi-automated using https://github.com/myii/ssf-formula/pull/306

myii commented 3 years ago

Merged, thanks @alxwr @baby-gnu.

saltstack-formulas-travis commented 3 years ago

:tada: This PR is included in version 1.4.0 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket:

saltstack-formulas / php-formula