Add KDE neon to list of Ubuntu derivates (again)

saltstack / salt-bootstrap

Generic Salt Bootstrap Script

Other

927 stars 551 forks source link

Add KDE neon to list of Ubuntu derivates (again) #2016

Closed digitalkram closed 2 months ago

digitalkram commented 2 months ago

What does this PR do?

Added KDE neon to list of Ubuntu derivates (again)

What issues does this PR fix or reference?

Previous Behavior

When run on KDE neon bootstrap-salt.sh terminated with ERROR: No dependencies installation function found. Exiting....

New Behavior

When run on KDE neon bootstrap-salt.sh now doesn't terminate with the above error but works as intended.

rolszewo commented 2 months ago

please merge this little, but helpful PR. i have the same problem.

dmurphy18 commented 2 months ago

@digitalkram Sorry about forgetting to add neon to the UBUNTU_DERIVATIVES. Just checking but are the neon_xx_ubuntu_base correct ?, also there are failing tests, look unrelated but all tests should be passing before it can be merged.

dmurphy18 commented 2 months ago

But those failing tests appear unrelated to your changes, see https://github.com/saltstack/salt-bootstrap/pull/2003 Looking into why 3007.0+xxxxx is getting used rather than current 3007.1+xxxxx from Salt git master, etc.

digitalkram commented 2 months ago

Afaict neon_xx_ubuntu_base are correct

dmurphy18 commented 2 months ago

@digitalkram FYI, releases bootstrap with your fix, 2024-090-24 version