search

saltstack / salt-ext-modules-vmware

Salt Extension Modules for VMware
Apache License 2.0
20 stars 36 forks source link

Get configuration and get desired configuration using config modules #389

Closed jgangel closed 1 year ago

jgangel commented 1 year ago

Call get desired configuration ready

Implement get configuration and get desired configuration execution modules

Fix on get configuration and get desired configuration return

Add get configuration and get desired configuration documentation

dmurphy18 commented 1 year ago

Just noticed from examining the tests run, that there is no Python 3.10 testing. This needs to get added, will investigate getting this added to the repo

jgangel commented 1 year ago

Yes @dmurphy18, is there a way to mark this PR as draft? I am currently working on the pytest for these changes done. Also, this is not expected to be merged into main, only to our unified-config branch.

dmurphy18 commented 1 year ago

@jgangel I see you found 'draft', also on the Salt Team we prepend [WIP] for Work In Progress to let others know it is not finished yet, for example:

[WIP] Get configuration and get desired configuration using config modules

As for unified-config branch, it is expected that some day it will be merged into the main branch, or else it should be in its own repository. Also need to test on Python 3.10 since that is what Salt 3006.x uses and you want to make sure there are no hidden gottas.