search

saltstack / salt

Software to automate the management and configuration of any infrastructure or application at scale. Install Salt from the Salt package repositories here:
https://docs.saltproject.io/salt/install-guide/en/latest/
Apache License 2.0
14.22k stars 5.49k forks source link

Add Netscaler moduler for Windows Server 2012 R2 #43555

Closed doesitblend closed 5 years ago

doesitblend commented 7 years ago

Description of Issue/Question

I would like to request the Windows Server 2012 R2 support for the Netscaler module. It appears that at the moment the module checks if it's on Windows and just returns a failure and does not attempt to load the module.

Versions Report

Master: 2016.11.7 Minion: 2017.7.1

garethgreenaway commented 7 years ago

@terminalmage Looks like you added the code that checks if the module is running on Windows, are the python libraries in use not support on that platform?

terminalmage commented 7 years ago

I think you may be mistaken, here:

% git log --oneline --pretty="%an" salt/modules/netscaler.py | grep "Erik Johnson" | wc -l
0

It looks like it was limited to non-windows from the very beginning. As long as the nsnitro module is compatible with Windows, I see no reason to limit it to non-windows. But I'm not at all familiar with nsnitro.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.