search

saltyorg / Sandbox

Saltbox Sandbox
GNU General Public License v3.0
63 stars 91 forks source link

Add Cockpit role with default variables and tasks #332

Closed RaneyDazed closed 2 months ago

RaneyDazed commented 4 months ago

This pull request adds the Cockpit role to the sandbox.yml file and includes the necessary default variables and tasks for the role.

RaneyDazed commented 4 months ago

Ok. So its not quite ready yet, I was hoping you could take a look and give me an idea of what the hell I did that wasn't up to the salty standard. I left some comments on purpose. Just be nice 😅

RaneyDazed commented 4 months ago

fwiw, it works fine. I just know that its not perfect. :p

saltydk commented 4 months ago

Probably also worth mentioning that this role does not install the VM bits, so either make that the default or add a toggle to install it along with any other system dependencies.

RaneyDazed commented 4 months ago

Probably also worth mentioning that this role does not install the VM bits, so either make that the default or add a toggle to install it along with any other system dependencies.

I'll be working on that after I fix everything else. Going to get plain jain cockpit going, make sure there's no issues from your POV, then I'll mess w the VM portion.

RaneyDazed commented 4 months ago

Ok, work in progress VM stuff added. I think I need someone else to test it though. I don't use any VMs right now, and idk what I would do to test it.

RaneyDazed commented 4 months ago

Better?

RaneyDazed commented 4 months ago

Maybe try using traefik_host here as it should do the empty subdomain check for you.

It works fine with traefik_host.

Edit

I did test it on my server.

saltydk commented 4 months ago

3AM here so I'm gonna pass on reviewing more until tomorrow.

RaneyDazed commented 4 months ago

3AM here so I'm gonna pass on reviewing more until tomorrow.

all good salty! Thanks!

RaneyDazed commented 4 months ago

need to update it for the network start. everything is great except for that VM task.

saltydk commented 4 months ago

I'm not really going to go over everything as then I'd prefer making the role myself anyway when I get around to doing it. Get someone to test it and if it works well enough for @owine's requirements then merge it.

maximuskowalski commented 3 months ago

@RaneyDazed

RaneyDazed commented 3 months ago

@RaneyDazed

Sorry max, I started a new job that begins at 6am and I've just been busy. I'll get to it asap I promise.

RaneyDazed commented 3 months ago

@maximuskowalski when you have a moment, could you take a look? thanks!

RaneyDazed commented 2 months ago

@owine I think we're done with this. I copied the qbittorrent stuff, and that should be sufficient according to salty. I tested with 2 diff servers, removed and added sso. Didn't try to add any custom middleware though.