integration tests: use wait-loop to check resources cleanup

samba-in-kubernetes / samba-operator

An operator for a Samba as a service on PVCs in kubernetes

Apache License 2.0

108 stars 24 forks source link

integration tests: use wait-loop to check resources cleanup #232

Closed synarete closed 2 years ago

synarete commented 2 years ago

Use simple wait-loop to ensure all k8s resources used by test are no longer active. In case not all resources have been removed, emit the relevant details to log.

Signed-off-by: Shachar Sharon ssharon@redhat.com

phlogistonjohn commented 2 years ago

/retest centos-ci/sink-clustered/mini-k8s-1.24

synarete commented 2 years ago

LGTM Thanks! I like the use of logf to help pinpoint what differs now that the require.Equal lines won't be aiding with that.

Please wait we merge to master -- while testing over OpenShift I realized that we may need another patch on top of this one.

phlogistonjohn commented 2 years ago

OK.