samba-in-kubernetes / sit-environment

SIT (Samba Integration Testing) Framework
GNU General Public License v3.0
1 stars 7 forks source link

sit.cephfs: Add share configured with `vfs_ceph_new`(non-mgr) #116

Closed anoopcs9 closed 2 weeks ago

anoopcs9 commented 1 month ago

depends on #117

spuiuk commented 1 month ago

I think instead of adding a new variable, we should just add to the list of variants. "vfs_new"?

anoopcs9 commented 1 month ago

I think instead of adding a new variable, we should just add to the list of variants. "vfs_new"?

There are multiple aspects to be considered here:

Let me know if you had something else in your mind.

anoopcs9 commented 1 month ago

I think instead of adding a new variable, we should just add to the list of variants. "vfs_new"?

I think I'll reverse the order here to first make the change to group possible shares(starting with cephfs) and then rework this PR to add another share(using _vfs_cephnew) on top of it.

spuiuk commented 1 month ago

I think the code is far too complex now with a number of if conditions causing it to split into multiple code paths. This change adds another such conditions. I think it would be far easier to go straight to grouping now.

dpulls[bot] commented 1 month ago

:warning: Dpulls not installed on repository ceph/ceph. Checkout our quickstart for how to install.

anoopcs9 commented 1 month ago

/retest centos-ci/xfs

dpulls[bot] commented 2 weeks ago

:tada: All dependencies have been resolved !