samber / lo

💥 A Lodash-style Go library based on Go 1.18+ Generics (map, filter, contains, find...)
https://pkg.go.dev/github.com/samber/lo
MIT License
18.02k stars 830 forks source link

Ellipsis: Replace "..." by "…" (U+2026) ? #518

Open samber opened 3 months ago

samber commented 3 months ago

suggested by @NathanBaulch in https://github.com/samber/lo/pull/470

ccoVeille commented 3 months ago

I also prefer using Unicode ellipsis, but I'm a not afraid about the consequence about such a change

maybe you could provide a way to provide the character via a parameter (or via another method), but then I'm a bit afraid no one will use the Unicode Ellipsis unless there is one method for 3 dots and one for Ellipsis.

But the public code using lo.Elipsis is very limited. https://github.com/search?q=%22lo.elipse%22+language%3AGo+&type=code

So I would say go for using Unicode one