search

samcday / phrog

🐸 Mobile device greeter
GNU General Public License v3.0
5 stars 0 forks source link

Keypad shuffle quick-setting plugin #6

Open samcday opened 4 months ago

samcday commented 4 months ago

https://phosh.mobi/posts/custom-plugins-dev/

Idea: add a toggle to switch keypad shuffle on/off

samcday commented 4 months ago

I think it should be possible to construct a QuickSettings subclass from phrog and get it noticed in the plugin system without too much effort?

That's what I'm hacking on this evening.

samcday commented 4 months ago

Implemented in 8f000e49b93b4cf2d85e70f778501239882f81b5

samcday commented 1 month ago

Reopening because this isn't quite done yet. Now that phrog is using upstream libphosh releases, I'm waiting on this MR to land (hopefully in 0.42.x): https://gitlab.gnome.org/World/Phosh/phosh/-/merge_requests/1494

samcday commented 1 month ago

In the meantime, I could keep the code properly included and built in CI, but gated behind a Cargo feature and excluded from distro packaging.

samcday commented 4 weeks ago

I need to get #37 done before this, as it requires a patch that I've opened upstream but hasn't landed yet (and I have no idea if it will, actually...)

samcday commented 3 weeks ago

The feature is back in main, behind a cargo feature flag that is only enabled for the static vendored build. It has a basic test that verifies the behaviour and provides a solid bit of footage for #18

The necessary plugin changes in upstream Phosh have landed and will be released in 0.42.0, so I can enable this feature properly soon enough. I'll keep the issue open until then.

samcday commented 3 weeks ago

@agx here is a GIF for your viewing pleasure :sweat_smile:

output

(not sure why the second test case is included in that recording. I only just landed the code that adds a second integration test so obviously something has gone slightly awry :upside_down_face: )