samedifferent / morevillagers

🏠 A Minecraft mod that adds more villagers, trades, and workstations.
https://www.curseforge.com/minecraft/mc-mods/more-villagers
Other
40 stars 30 forks source link

[Bug]: Frequent Customer advancement not achievable #45

Closed Jigglypie closed 2 years ago

Jigglypie commented 2 years ago

Mod Version

1.18.1

Mod Loader

Fabric

Mod Loader Version

0.12.12

What happened?

It appears that one of the traders does not count towards the 21 total trade requirements for the achievement "Frequent Customer." After replicating it in a singleplayer world with only More VIllagers loaded, it appears that the Miner trader is the one that does not count towards the achievement.

To confirm this is the case, I viewed all_professions_traded.json, and it does not seem that miner is mentioned anywhere, and only 20 total traders are in the code.

latest.log

[17:54:18] [main/INFO]: Loading Minecraft 1.18.1 with Fabric Loader 0.12.12 [17:54:18] [main/INFO]: Loading 52 mods:

samedifferent commented 2 years ago

@PhoenixVX it is because the miner's namespace in all_professions_traded.json is morevillagers:miner when it should be minecraft:miner, like all the others are. This is only a fabric inconsistency.

PhoenixVX commented 2 years ago

Closing as this should be fixed in: https://github.com/samedifferent/morevillagers/commit/3c13f93926e53867a8fabf6eed57807c7dc484c5

Re-open if the issue still occurs, please and thanks!