search

samedifferent / morevillagers

🏠 A Minecraft mod that adds more villagers, trades, and workstations.
https://www.curseforge.com/minecraft/mc-mods/more-villagers
Other
40 stars 30 forks source link

profession's own modid #52

Closed Laifsyn closed 2 years ago

Laifsyn commented 2 years ago

Mod Version

1.18.2-3.2.0

Mod Loader

Fabric

Mod Loader Version

0.14.6

What happened?

I was checking my CraftTweaker's dumps, and I noticed that your profession shares the same namespace as vanilla Minecraft(aka. minecraft:engineer ). I would suggest to change the namespace to the mod's name for generalization sakes

latest.log

nan

samedifferent commented 2 years ago

This only occurs on fabric, and vanilla just decides to use the Minecraft namespace for them. I noticed this with other mods that add new villagers, so I don't think it's something I can change, and it doesn't affect anything.