search

samolego / FabricTailor

A server-side or singleplayer skin changing mod for fabric.
https://modrinth.com/mod/FabricTailor
GNU Lesser General Public License v3.0
109 stars 17 forks source link

[BUG] /skin set player <playername> has abnormal behavior #30

Closed Derpitron closed 3 years ago

Derpitron commented 3 years ago

When using FabricTailor 1.5.1 for 1.17, using /skin set player <playername> has different unintended effects. First, i tried to run /skin set player Derpitron (my name) image

and it did not work. Then, I tried random names like Technoblade, Dream and DanTDM, all of which worked as expected and set the skin properly.

after that I tried to run /skin set player Derpitron again which had a different effect. image the skin says it was set, but my skin did not change from DanTDM's skin to mine at all.

When I relogged, the skin reset back to Steve. this happened both when I set the skin as DanTDM normally and my name. I also tried a few other names like my friend's names but it did not work, similar to Derpitron. the effects were different depending on the player's name.

I am assuming that the mod is pulling skins from a website that has celebrities skins stored but not regular skins. Please fix this as soon as possible, as we are playing on an offline server and I cannot always access the mods/config files.

samolego commented 3 years ago

Humm, it might be related to the fact that you're running offline mode server. Not sure about it, did it happen on 1.16? As there were some changes I made to skin fetching ...

Saving is related to #29 .

Derpitron commented 3 years ago

I am running on an offline mode server. and no, this bug did not happen on 1.16.5, actually none of these bugs happened

brenodantas10 commented 3 years ago

Okay, this bug is happening to me now in 1.16.5. Server set to offline, can set skin to famous players but not me...

EDIT: using version 1.5.0 of the mod for compatibility