search

sampart / cordova-plugin-app-version

Cordova plugin to return the version number of the current app [not maintained]
MIT License
401 stars 196 forks source link

Browser version failing to find config.xml #128

Closed Djones4822 closed 2 years ago

Djones4822 commented 2 years ago

Cordova version 11.0.0

Issue: Using the browser build, the xhr request fails to locate the file config.xml

I think this is because the xhr request to ../config.xml is searching the parent of the root - I think this would be solved by just using config.xml .

This is based on my understanding of the directory structure: https://cordova.apache.org/docs/en/11.x/reference/cordova-cli/index.html#directory-structure

Is there a specific reason that ../config.xml is used that I'm not aware of?

Also, I'm aware that the repo is unmaintained, I'm hoping there's anyone who objects to my proposed fix, I will submit the PR if not.

sampart commented 2 years ago

Fixed in #129 ❤️