search

samriddh2145 / pe

0 stars 0 forks source link

Error message is not specific for invalid index in bookmark command #1

Open samriddh2145 opened 4 months ago

samriddh2145 commented 4 months ago

Actual - When the index in bookmark command is zero or negative, the general invalid command error is displayed.

Screenshot 2024-11-15 at 4.48.10 PM.png

Expected - the error message can be made specific and state invalid index, like in the case when index is out of range.

Screenshot 2024-11-15 at 4.49.16 PM.png

nus-pe-script commented 3 months ago

Team's Response

It has been stated in the UG that the command format for bookmark command is bookmark INDEX where INDEX refers to a positive integer. Hence, any parameter that does not conform to this requirement is an invalid command which has also been stated in the UG.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: The developer team seems to have misunderstood the nature of the bug. While using a negative index in the command is indeed invalid, the issue lies in the error message displayed when such an index is used. Currently, the error message for a negative index is the same as the general invalid command message. However, it would be more helpful and consistent to provide a specific error message for negative indices, similar to how a distinct message is provided when the index is out of range.