samriddh2145 / pe

0 stars 0 forks source link

Improve phone number validation #4

Open samriddh2145 opened 4 months ago

samriddh2145 commented 4 months ago

Actual - User can add an all zero phone number and extremely long phone numbers.

Screenshot 2024-11-15 at 5.00.04 PM.png

Expected - Phone number validation can be improved to not validate all zeroes or extremely long phone numbers.

nus-pe-script commented 3 months ago

Team's Response

The application is designed to accept a wide range of phone numbers to accommodate various valid scenarios, including edge cases like testing environments or placeholder data.

If stricter validation is deemed necessary, it can be implemented as an optional enhancement, allowing users to configure or enforce specific formats based on their needs. However, this is not a critical issue and does not require immediate action

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I agree that implementing stricter phone number formats can be considered an additional feature and can be added in future iterations. However, basic validation, such as disallowing all-zero numbers and setting a reasonable limit on the length of phone numbers (even a high limit), is a basic expectation and aligns with the expected functionality of the application. These measures would significantly improve the user experience. While these enhancements can be deferred to future updates, marking the issue as "not in scope" would be more appropriate than rejecting the bug outright.