samuelclay / NewsBlur

NewsBlur is a personal news reader that brings people together to talk about the world. A new sound of an old instrument.
http://www.newsblur.com
MIT License
6.82k stars 995 forks source link

Newsletters don't refresh without login to web UI #1821

Open quad opened 11 months ago

quad commented 11 months ago

I'm using NetNewsWire to access Newsblur.

Newsletters will stop refreshing without me periodically logging in via a browser to newsblur.com.

samuelclay commented 11 months ago

I wish NetNewsWire would hit the /reader/refresh_feeds endpoint, as that refreshes the login date and keeps your feeds current.

samuelclay commented 11 months ago

Here's the code that needs to be hit to ensure you're still a current user:

https://github.com/samuelclay/NewsBlur/blob/c9f573eca35e83726668610c0867fc8f1b74c183/apps/profile/middleware.py#L22-L25

But it looks like NNW is hitting that:

https://github.com/Ranchero-Software/NetNewsWire/blob/5e3086667d91ef5b92597f44215cd90785052bd2/SyncClients/NewsBlur/Sources/NewsBlur/NewsBlurAPICaller.swift#L77

quad commented 11 months ago

Yeah, the weird part is that feeds work normally. It’s only newsletters that stop refreshing after several days.

I tried tracing the newsletters refresh job but couldn’t see if something was triggering it that might be missed by NNN.

quad commented 2 months ago

@samuelclay Here's a video showing the issue…

https://github.com/samuelclay/NewsBlur/assets/24025/7d42a139-2b01-4dde-9096-90de3000b1a8

quad commented 2 months ago

My new theory is that the newsletter (and other) feeds are needs_unread_recalc = True, and the following code is preventing unread counts from being updated…

https://github.com/samuelclay/NewsBlur/blob/db30d559a08a3d7014668a3c29e765fd0560d4db/apps/reader/views.py#L339-L343

quad commented 2 months ago

Two proposals:

  1. https://github.com/samuelclay/NewsBlur/pull/1871 stops letting the Android client get away crime 😉
  2. https://github.com/samuelclay/NewsBlur/pull/1872 normalises status quo … and then I can open a PR on NNW to set update_counts to true
quad commented 2 months ago

I wish NetNewsWire would hit the /reader/refresh_feeds endpoint, as that refreshes the login date and keeps your feeds current.

What's the difference between the load_feeds and refresh_feeds endpoints? That is, could the cached/rate-limited aspects of refresh_feeds be internalised to `load_feeds?