samuelcolvin / rtoml

A fast TOML library for python implemented in rust.

https://pypi.org/project/rtoml/

MIT License

323 stars 28 forks source link

Test against, officially support Python 3.11 #46

Closed homeworkprod closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #46 (d678099) into main (2c50761) will not change coverage. The diff coverage is n/a.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #46 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 1 1 Lines 28 28 Branches 5 5 ========================================= Hits 28 28 ```

homeworkprod commented 2 years ago

cargo clippy raises errors, but that's also the case on main.

Tried a few of its suggestions but they did not fix the issue for me.

samuelcolvin commented 2 years ago

Thanks so much for this, I've fixed linting, and also migrated to maturin for build to fix build issues.

I've tried to push to your PR to merge the changes on main, but unfortunately you've blocked me from contributing to your PR.

For the sake of speed, I'll delete this and copy the changes to a new PR.

homeworkprod commented 2 years ago

Cool, thanks!

but unfortunately you've blocked me from contributing to your PR.

Not sure where I could've influenced that for this PR, but I'll keep an extra eye open in the future.

samuelcolvin commented 2 years ago

Not sure where I could've influenced that for this PR, but I'll keep an extra eye open in the future.

When you create a PR, there's an option to "Allow edits...", this must be check for me to be able to push to your PR.

homeworkprod commented 2 years ago

That's strange. I have seen this option before, but I did not encounter it with this PR, and I just attempted to create another one (from my fork to the source repo) which also doesn't give me that option (including switching between draft and non-draft):

github-pr-no-option-to-allow-edits

samuelcolvin commented 2 years ago

Oh, perhaps it's because the pr is in draft?

homeworkprod commented 2 years ago

What I was trying to say was that I flipped between draft and non-draft using the dropdown functionality of the big green button and it did not result in that checkbox being shown in either state.

Maybe it's only shown when using a different path to create a PR, or there is some user default setting I did not unearth yet, but so far I could not find a way to allow PR edits by maintainers.

Not sure why this is, but it's probably worth keeping in mind that a user might not have the chance to make that decision.

samuelcolvin commented 2 years ago

Interesting, I often edit PRs of contributors. It's extremely rare (I guess <5% of the time) that I can't push to a PR.