search

samuelcolvin / watchfiles

Simple, modern and fast file watching and code reload in Python.
https://watchfiles.helpmanual.io
MIT License
1.79k stars 108 forks source link

Cargo.toml: Update PyO3 to 0.22.1 #286

Closed EwoutH closed 4 months ago

EwoutH commented 4 months ago

Updates the PyO3 dependency to 0.22.1 in Cargo.toml. This should help with Python 3.13 compatibility.

EwoutH commented 4 months ago

I have no idea about the CI failures. There is a migration guide for PyO3, it might be helpful: https://pyo3.rs/v0.22.1/migration

edgarrmondragon commented 4 months ago

~@EwoutH you might wanna take a look at https://github.com/crate-py/rpds/pull/79 for a similar migration to PyO3 0.22.1~

I see you commented there 😅

EwoutH commented 4 months ago

Thanks for the reference! Unfortunately, I can't fix this myself, I'm not a Rust dev. Just following the rabbit hole of upstream dependencies.

I hope anyone would be able to work on this!

samuelcolvin commented 4 months ago

you'll need to update Cargo.lock too.

I would say these are real compatibility issues related to the new PyO3 API that will need to be fixed.

EwoutH commented 4 months ago

Thanks, I'm going to close this PR, since I'm not going to be able to fix it. We can use #276 to track this issue further.