samuelmeuli / action-electron-builder

:electron: GitHub Action for building and releasing Electron apps
MIT License
658 stars 201 forks source link

✨ Add `skip_install` #60

Open CryogenicPlanet opened 3 years ago

CryogenicPlanet commented 3 years ago

Already has a skip_build option I think a skip_install in the same vain can be useful for people who want to cache package installation or use something like pnpm

It is a very minor change hence didn't make a detailed PR

imolorhe commented 3 years ago

Exactly what I need for #61

CryogenicPlanet commented 3 years ago

As a temporary fix @imolorhe you can directly use that repo.

Also adding closes #61

- name: Build/release Electron app
        uses: cryogenicplanet/action-electron-builder@v2
        with:
          # GitHub token, automatically provided to the action
          # (No need to define this secret in the repo settings)
          github_token: ${{ secrets.github_token }}
          skip_install: true

          # If the commit is tagged with a version (e.g. "v1.0.0"),
          # release the app after building
          release: ${{ startsWith(github.ref, 'refs/tags/v') }}
imolorhe commented 3 years ago

@CryogenicPlanet already did 😄 I needed it urgently https://github.com/imolorhe/altair/commit/13f6d2005650a7e195b87378715889e069add3ce It works perfectly. Thank you

markxoe commented 3 years ago

Any way of getting this merged soon? 😄

mifi commented 2 years ago

@samuelmeuli do you need help maintaining this project? I'll volunteer

andirsun commented 2 years ago

We are using this action at my company so We can maintain it as well

imyanice commented 1 year ago

If you wish to use an updated version & see your PR accepted go here: https://github.com/Yan-Jobs/action-electron-builder