samuelneff / MimeTypeMap

Provides a huge dictionary of file extensions to mime types.
MIT License
625 stars 201 forks source link

Added some const strings, fixed some typos and add default value for GetExtension method #95

Closed StefH closed 4 years ago

StefH commented 4 years ago
samuelneff commented 4 years ago

@StefH Thanks for the great additions and corrections. Everything in the map file is perfect.

I can't accept the project file changes though. Some people are dependent on that specific targeting. If you can undo just that change for the PR I'll be grateful to merge the rest of the changes.

StefH commented 4 years ago

Hello @samuelneff, I can revert the TargetFrameworks change, however I would like to explain why I did this: all I did was lower the dependencies, which is good because more projects / people can use it.

I you still would like to keep the TargetFrameworks as-is, no problem, I'll revert this in the PR.

samuelneff commented 4 years ago

Thanks for explaining. I haven't programmed in .NET myself in years so I don't know enough to discuss the impact of the project change. I'd prefer if you left the project as is simply to maintain status-quo.

I appreciate your understanding.

Sam

StefH commented 4 years ago

OK. I've reverted the changes on TargetFrameworks. Maybe I'll create a new issue on this and let other users comment on this.

When do you plan to release a new NuGet ?

samuelneff commented 4 years ago

@StefH Thanks for the updates. I don't control the NuGet packages. A few other people have published them but it's not something I've been involved with.