search

samvera-deprecated / sufia

[DEPRECATED] Sufia: a fully featured, flexible Samvera repository front-end.
http://sufia.io/
Other
111 stars 78 forks source link

Adding a child work causes the edit form's lock to go stale #3127

Closed hackartisan closed 7 years ago

hackartisan commented 7 years ago

And then the form cannot be saved.

Descriptive summary

7.3.rc3

Expected behavior

Adding a child work, then submitting the form via the save button, should result in the child work being attached plus any other changes being applied.

Actual behavior

Adding a child work then submitting the form results in the error message "Another user has made a change to that Work since you accessed the edit form."

Steps to reproduce the behavior

  1. Create 2 works
  2. Edit the first work and add the second as a child.
  3. Click 'save'

Related work

https://github.com/projecthydra/sufia/pull/3066 https://github.com/projecthydra/sufia/commit/798495543e99cf84707dba64fe45de150e9548b7

mjgiarlo commented 7 years ago

We have some issues in Hyrax related to this, namely projecthydra-labs/hyrax#325 and projecthydra-labs/hyrax#326. It may make sense to do this in Sufia now.

hackartisan commented 7 years ago

I have some time today and maybe tomorrow to look at moving this from ajax submission to regular form submission. @dlpierce if you have any WIP to share please do

re: https://github.com/projecthydra-labs/hyrax/issues/325#issuecomment-278108116

hackartisan commented 7 years ago

Releasing this for now; I didn't get very far before having to take some time with a sick kid.