search

samvera / hydra-head

Samvera Repository Rails Engine
Other
98 stars 41 forks source link

hydra-access-controls 10.x is not compatible with blacklight-access_controls 0.7 #464

Closed cjcolvar closed 6 years ago

cjcolvar commented 6 years ago

This is leading to a RuntimeError on nurax:

You may not use Blacklight::AccessControls::SearchBuilder and include Blacklight::AccessControls::Enforcement on SearchBuilder at the same time

@samvera/hydra-head

jrochkind commented 6 years ago

Chris Colvard [11:40 AM] @jrochkind yes, the latest blacklight-access_controls that was cut this morning is for supporting blacklight 7. hydra-access-controls master was recently rolled back from a long unreleased (until this morning) version of blacklight-access_controls which was blocking the ability to make changes and release a new version of blacklight-access_controls for hyrax. The decision was made to not push BL7 related breaking changes into master yet and be deliberate about making that change. Once this PR is merged and a release cut I don’t see why changes for BL7 couldn’t come into master and @jcoyne already made a PR to that effect: https://github.com/samvera/hydra-head/pull/463