samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
184 stars 124 forks source link

batch add new works doesn't add new works #5453

Open rjkati opened 2 years ago

rjkati commented 2 years ago

Descriptive summary

On nurax-pg, I can complete the process to create a batch of works, but works do not display in my works list. It is not clear to me whether the deposit process has completed.

Acceptance Criteria

Make https://github.com/samvera/hyrax/pull/6266 pass tests.

Expected behavior

After creating a batch of works, each work should display in my works list on the dashboard. This should function for all work types.

Actual behavior

After creating a batch of works, works in the batch do not display in the works list on my dashboard

Steps to reproduce the behavior

  1. Make sure that "batch upload" is enabled on nurax-pg.
  2. Navigate to the Works page on the dashboard. Make note of the number of works on your dashboard
  3. Click the "Create batch of works" button and select "generic work" or "monograph"
  4. Upload several files and fill out the required metadata
  5. Check the deposit agreement box and click Save.
  6. Observe that the number of works that are listed on your dashboard has not changed and the works added via batch don't appear.
rjkati commented 1 year ago

This issue is still present on pg.nurax (Hyrax 4.0.0.rc2)

tpendragon commented 1 year ago

We're working on trying to get instructions on enabling bulk upload.

eliotjordan commented 1 year ago

Note: BatchCreateJob calls CreateWorkJob which creates non-Valkyrie works.

Probably need a new job and switch between the two. Something like:

if ActiveFedora::Base
  CreateWorkJob.perform
else
  CreateValkyrieWorkJob.perform
end
dlpierce commented 1 year ago

I am able to batch create GenericWorks in koppie, but this seems to not function for Monographs. I noticed the form shown does not match the regular monograph form and so the required field "Record Info" cannot be filled.