search

samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Add presentation role to list items #6938

Closed rkuehn-uofl closed 3 weeks ago

rkuehn-uofl commented 3 weeks ago

Fixes

Fixes #6797 Fixes #6809

Summary

Corrects accessibility issue with list items in new user form. Adds role="presentation" to <li class="nav-item"> elements to prevent ARIA semantics from unnecessarily being exposed.

Type of change (for release notes)

notes-minor Adds presentation role to list items for accessibility

@samvera/hyrax-code-reviewers

github-actions[bot] commented 3 weeks ago

Test Results

    17 files  ±0      17 suites  ±0   2h 13m 46s ⏱️ - 3m 1s  6 717 tests ±0   6 420 ✅ ±0  297 💤 ±0  0 ❌ ±0  13 204 runs  ±0  12 808 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit fdee6785. ± Comparison against base commit 6b467fdd.

This pull request removes 266 and adds 266 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: a57ba9b5-06c2-4bfa-a47e-4eaa7a1fc3d9 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 48b507cc-7d0b-4b48-b7ee-a80eb7965a74 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b64580e0-5f0a-4c6b-9cb5-4b391db7b29f spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: d4c7f5b9-d63d-40ec-b5c9-7f776ba08164 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 0eedcc3c-5409-48c7-9813-fa37cebf2069 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 179e17ee-c691-480a-a19f-2776c5bb5d97 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 376baf4c-960f-48b8-841d-13dccd9e92ce spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 17019982-2915-4ca4-bc8e-e1099caa4d48 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 3c3bdd5f-e30a-4176-852a-a66690386ae5 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 610f05ed-9713-4328-aae1-8266c75a19f0 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 024e5b5f-579e-46b2-bc98-b99dce40a37e spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 1a071b12-dd30-4584-877b-caf76a16eae9 … ```

:recycle: This comment has been updated with latest results.