samvera / hyrax

Hyrax is a Ruby on Rails Engine built by the Samvera community. Hyrax provides a foundation for creating many different digital repository applications.
http://hyrax.samvera.org/
Apache License 2.0
185 stars 124 forks source link

Fixes accessibility issues with the member image partials in the File Manager #6962

Closed randalldfloyd closed 2 weeks ago

randalldfloyd commented 2 weeks ago

Fixes

Fixes #6812 Fixes #6813

Summary

Adds minor accessibility fixes to the partials that render the member image panels. It makes sure the thumbnails have text alternatives, and the edit title fields have labels.

github-actions[bot] commented 2 weeks ago

Test Results

    17 files  ±0      17 suites  ±0   2h 17m 53s ⏱️ + 2m 0s  6 729 tests ±0   6 432 ✅ ±0  297 💤 ±0  0 ❌ ±0  13 229 runs  ±0  12 833 ✅ ±0  396 💤 ±0  0 ❌ ±0 

Results for commit bdf986e1. ± Comparison against base commit c56c4a8a.

This pull request removes 267 and adds 267 tests. Note that renamed tests count towards both. ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: ac5954f2-73c7-43ba-a7cb-ba258dd9ce2f spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 3f8590fe-defd-45ab-8503-3fb4d9cd2a58 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: b9ff3af0-856f-46b3-b0f2-fcd06ed9672f spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 1695e35c-ea8e-4f96-bc21-8295acf9cd3d spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 1e355e41-0aa0-4fb1-95e6-b31618146bff spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 01455be7-5abb-47b6-ada6-0820e00027b0 … ``` ``` spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create # spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: eba172e8-1ffe-44da-90b7-6ff8962f27ba spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 00564882-38f7-4dd8-8128-f50c5da51c09 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 772552b1-21cb-4631-b65a-b20ec1b8e761 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 42d70dab-e830-441e-8f30-301b05cadc33 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: fa6ee8f4-cf80-4bea-85ab-997714742c20 spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 459a352a-9a67-48c5-b77f-34b7b69ea68a … ```

:recycle: This comment has been updated with latest results.