search

samvera / valkyrie

A Data Mapper library to enable multiple backends for storage of files and metadata in Samvera
Other
34 stars 23 forks source link

Add cleanup functionality to #disk_path #955

Closed tpendragon closed 6 months ago

tpendragon commented 7 months ago

Refs #954

dchandekstark commented 6 months ago

I like it, except for the temp file naming. I know that's not new, but I think the issue is exacerbated by auto-cleanup. Is there a strong motivation for the temp file naming practice?

tpendragon commented 6 months ago

I like it, except for the temp file naming. I know that's not new, but I think the issue is exacerbated by auto-cleanup. Is there a strong motivation for the temp file naming practice?

Nope! It's a good point! I can't look at it now but I can try to add something about it later today.

tpendragon commented 6 months ago

@dchandekstark Added

cgalarza commented 6 months ago

@tpendragon This looks great!