MCP2515 observe() implementation seems incorrect.

sandeepmistry / arduino-CAN

An Arduino library for sending and receiving data using CAN bus.

MIT License

696 stars 238 forks source link

MCP2515 observe() implementation seems incorrect. #106

Closed ddejean closed 1 year ago

ddejean commented 2 years ago

https://github.com/sandeepmistry/arduino-CAN/blob/382fff7a04673705fbd5bc79e6badd319a03c3a8/src/MCP2515.cpp#L356

I'm currently looking at the observe() method implementation for MCP2515 and I'm wondering if the line referenced above is correct. According to the datasheet, it seems the 0x80 value is for "Configuration mode". If I read the datasheet correctly, the value to use here should be 0x60.

What do you think ?

sandeepmistry commented 2 years ago

@ddejean would you be able to make a pull request for this change? Thanks.

ddejean commented 2 years ago

Sure I'm on it :)

sandeepmistry commented 1 year ago

Resolved by #107.