sanderrouk / AddcBuilder

Java application which builds ADDC Servers from Ubuntu servers using Samba 4 and SSH
https://sandervend.github.io/AddcBuilder/
2 stars 0 forks source link

bash -c password.... #1

Open azeller opened 7 years ago

azeller commented 7 years ago

Find a better way to pass along passwords. Maybe use public keys or certificates. Making the password therefore publicly visible to other users in ps seems like a very bad idea.

sanderrouk commented 7 years ago

I agree that the current way of handling the password is poor indeed and I do need to think of a better way to pass the password, a key or cert seems like a way worth investigating. The SSH will, however have to remain through a password for now, as the SSH framework being used does not support using keys to establish a connection, also worth redoing in the future. I appriciate the suggestion!