Open nigelmegitt opened 4 years ago
palemieux
commented
4 years ago Yes, it looks like the current implementation at applyFillLineGap() does not conform to the specification, which talks only about extended the background of inline areas. As I understand the above, an empty br does not generate an inline area.
nigelmegitt
commented
4 years ago Incidentally, it would be worth checking that a similar issue does not arise withlinePadding which would be demonstrated by the same test content. If there is no background being drawn for an empty line because it contains no inline area, then there is no inline area whose background should be extended in the inline direction either. This is significantly less clear in the specification pdf (to the point that I wonder if it is a specification bug) but it seems logical to apply the same rule.
When an empty line is inserted using a
<br/>it is considered by imscJS as generating an inline area even though it contains no text. The result is that whenitts:fillLineGapistrue, the background areas of the non-blank lines are extended in a strange way, between the lines that do contain text. At first I thought this might be a consequence of settingebutts:linePaddingbut that doesn't make any difference to the behaviour in the block-progression direction.I'm not sure if the blank line should indeed constitute an inline area (I think not), but this behaviour seems weird to me. Possibly this should be escalated to a specification issue, but raising here for discussion first, since potentially it is an implementation issue.
The test content below generates this sequence of images demonstrating the behaviour:
What should be the correct behaviour? It is permitted to insert empty lines with
<br/>even if it isn't good practice.I think the expectation would be that there should be a deliberate gap in the background area regardless of
itts:fillLineGapin this case, since there's no inline area generated for these empty lines.Example IMSC content used to generate the above images
```xmlNo linePadding, no blank lines below
Text
No linePadding, 1 blank line below
Text
No linePadding, 2 blank lines below
Text
No linePadding, 3 blank lines below
Text
linePadding, no blank lines below
Text
linePadding, 1 blank line below
Text
linePadding, 2 blank lines below
Text
linePadding, 3 blank lines below
Text