search

sandreas / m4b-tool

m4b-tool is a command line utility to merge, split and chapterize audiobook files such as mp3, ogg, flac, m4a or m4b
MIT License
1.12k stars 78 forks source link

MusicBrainz HTTP 404 #251

Closed cpiber closed 5 months ago

cpiber commented 5 months ago

Note sure if the API was made more strict, but the tool currently uses the release API for a work, which always returns 404.

Current request: http://musicbrainz.org/ws/2/release/8669da33-bf9c-47fe-adc9-23798a37b096?inc=recordings&fmt=json

Should be: http://musicbrainz.org/ws/2/work/2293df54-3571-4cb1-9758-a0be7094f988?inc=recording-rels&fmt=json

cpiber commented 5 months ago

Correction, it seems some Audiobooks are available as both a release and a work. The example in the Readme is of a work though, so this issue is still correct.

Generally, I was trying to figure out how to use the MBID and noticed that there is a bug. It is currently impossible to use the MBID with the chapter command, since the result of the parser is discarded. In https://github.com/sandreas/m4b-tool/commit/ded25b6b17438609480268dae6e8f8e53ed88c2d you changed building of chapters, which means $parsedChapters goes unused when MBID is enabled. Assigning instead to $this->chapters seems to work fine; I'll open a PR with all of this a bit later after some more testing.