sanger / traction-service

Ruby on Rails exposing a RESTful API for a Long Read LIMS
https://traction.psd.sanger.ac.uk
MIT License
4 stars 5 forks source link

Y24-320 - [BUG] For the new PiMmS_TruSeq_adapters_v1 libraries or pools should be treated as untagged but the the hidden sample sheet bheviour is not working as expected for the new style sample sheets #1434

Open stevieing opened 2 weeks ago

stevieing commented 2 weeks ago

Describe the bug

Thanks for making Live in production. In my haste, I've just realised that I performed UAT as if it is a normal Tag set. Previously, we had the functionality with the TruSeq_CD_i7_i5 tag group that if selected the libraries or pools would be treated as if they are untagged, the biosample name would be a concatenation of all the samples in the pool - the customer deplexes these samples as the tags are asymmetric so unsupported in TRACTION. I think this may have 'broken' with the new csv format. Runs containing libraries with the TruSeq tag group now export a csv file that contains tagged libraries rather than treating them as untagged. The new PiMmS tag set should be treated the same way. I suspect that this is not a quick fix and I have some libraries to load using this tag group. However, I can manually edit the csv file to replicate the previous functionality for the 'Bio Sample Name' row so I can get the libraries sequenced (assuming this is not going to cause any major problems). RT Ticket Number If applicable

To Reproduce Steps to reproduce the behaviour:

  1. Go to page '...'
  2. Click on button '...'
  3. See error

Expected behaviour What was expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Additional context Add any other context about the problem here.

stevieing commented 1 week ago

Incorrect sample sheet: TRACTION-RUN-1504.csv

Correct sample sheet: TRACTION-RUN-1504-edit.csv

stevieing commented 3 days ago

Investigation:

In summary:

stevieing commented 11 hours ago

I have created a new story to refactor the code to make it easier to maintain #1443