Enable drag & drop sorting for custom combat features

sangheili868 / StarWars5e.Site

The frontend web app project for StarWars5e

30 stars 14 forks source link

Enable drag & drop sorting for custom combat features #31

Closed cynicaloptimist closed 4 years ago

cynicaloptimist commented 4 years ago

This is my first time using Vue so I'm happy to take this back to the drawing board. Possible improvements:

Extract a local Draggable higher-order component with the computed and $emit calls
Apply this pattern to other custom features (e.g. inventory)

cynicaloptimist commented 4 years ago

Made initial changes, I'll poke around to see about adding an HOC later, maybe tonight.

cynicaloptimist commented 4 years ago

Using this for equipment is problematic since it appears that weapon overrides are keyed by index. I did extract an HOC for this, but it's only used in the one place. I think it's ready to merge.

cynicaloptimist commented 4 years ago

Right on, thanks for merging, happy to contribute!

sangheili868 commented 4 years ago

I'll try to get it deployed to prod tonight

sangheili868 commented 4 years ago

Also, if you are in the SW5E discord, message me @Tyrzaphir and I will make sure to mention you when I post in the #website-new-releases channel