vercel[bot]
commented
5 days ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| live-visual-editing-next | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-astro | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-next | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-next-with-i18n | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-nuxt | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-page-builder-demo | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-remix | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-storybook | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
| visual-editing-svelte | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Nov 18, 2024 5:28pm |
This is kind of a fix dressed up as a feat.
Accessing optimistic document snapshots is currently error prone as it is assumed the snapshot will be available, in actual fact it may not be as snapshots have to be fetched from Content Lake via Presentation tool. In most situations this is fine as user interaction is required to trigger some document snapshot getter and so will likely not occur immediately
doc.get()returns a snapshot and throws if the snapshot is unavailable. This is now deprecated.doc.getSnapshot()replaces it. It returns a promise which is resolved when the snapshot is actually returned.As a result the Context Menu now has a loading state (video below demonstrates this with an artificial 5s delay added to snapshot fetching), and interactions like drag and drop will await the snapshot resolution before patches are applied, rather than just throwing.
Similarly
doc.patch((context) => {...}will currently throw if used before snapshots have been fetched. In this PRsnapshotis deprecated but still available on this context object, however the property has been replaced with a getter so that it will not throw unless explicitly accessed.snapshotis replaced withgetSnapshotwhich similarly returns a promise.https://github.com/user-attachments/assets/38ad7c1b-68b8-4d17-95f9-da2ee5523ff3