search

sanni / cartreader

A shield for the Arduino Mega that can back up video game cartridges.
GNU General Public License v3.0
2.23k stars 226 forks source link

replace cart selection code of A7800 with one used at NES, COLV, INTV, WSV #935

Closed smesgr9000 closed 7 months ago

smesgr9000 commented 7 months ago

please review https://github.com/sanni/cartreader/pull/934 first. This one extends on this change.

This pull requests replaces the cart selection code of 7800 with the afaik more user friendly code of NES, COLV, INTV & WSV. Plus due to the code similarities the used space of the program is reduced in my configuration from 243718 to 242794 Bytes

Downside the cart database structure for the 7800 must be changed. If some user only update the firmware without the SD card - cart selection does not work until SD card is updated.

If this is ok - I would like to change 2600 and C64 as well.

PsyK0p4T commented 6 months ago

With latests commits, it looks like errors/warnings are now displayed when I try to compile the project with hw5 + lot of systems selected. Could be due to "&readDataLine_ARC" in the A2600 module

@smesgr9000 can you try to put your compiler warning option to "All" and have a look ? image