purpose of snes.ino "boolean altconf"?

sanni / cartreader

A shield for the Arduino Mega that can back up video game cartridges.

GNU General Public License v3.0

2.23k stars 226 forks source link

purpose of snes.ino "boolean altconf"? #973

Closed smesgr9000 closed 4 months ago

smesgr9000 commented 4 months ago

OSCR firmware version

V13.3

OSCR hardware version

HW5 Rev6

Attach OSCR_LOG.txt file here

No response

System used

SNES/Super Famicom

Describe the issue.

What is the purpose of the flag "altconf" in snes.ino? It seems it only toggles print lines between those variants: "Rom Size: " "ROM Size: "

It would like to remove this flag if it hasn't any other purpose.

sanni commented 4 months ago

I remember I created that variable to signal that the rom header of the SNES cartridge was wrong and instead the config from the snes.txt database was used.

"Rom Size: "
"ROM Size: "

was an indicator that this happened(for debugging) before I added the log file where you can now easily read that it got changed.

So yeah, you can remove it as it doesn't have a purpose anymore.

smesgr9000 commented 4 months ago

thanks for the explanation