Fails to rebuild for electron 28+ (v8 12+)

santigimeno / node-pcsclite

Bindings over pcsclite to access Smart Cards

ISC License

170 stars 125 forks source link

Open chrbongardt opened 6 months ago

chrbongardt commented 6 months ago

V8 v12 brings some breaking changes to the ObjectTemplate::SetAccessor signature. NAN is working on a fix: https://github.com/nodejs/nan/pull/966.

As soon as the fixing NAN version is released I will open a PR. Just wanted to have this tracked.

Thanks!

chrbongardt commented 6 months ago

Done, I just created PR #102 that should fix this.

chrbongardt commented 6 months ago

While this get's merged and released by @santigimeno you can use my branch by doing npm i git@github.com:chrbongardt/node-pcsclite.git#master

rkeithhill-keysight commented 3 months ago

Huh, nan 2.19.0 does not fix this issue for Electon 28 builds. I still get:

'v8::ObjectTemplate::SetAccessor': no overloaded function could convert all the argument types