Revert "PTF: enforce use_l2pop = true"

vuntz commented 7 years ago

This was only needed for one deployment, to not revert the l2pop setting on upgrade. But generally speaking, this hack should not be used anymore to not enable l2pop by accident for anyone.

This reverts commit daf51114ce5ad27d1b1ef144e7e95918498b6da9.

tpatzig commented 7 years ago

but this will not be set to false, if we merge and install that, because we have not enabled dvr?

vuntz commented 7 years ago

but this will not be set to false, if we merge and install that, because we have not enabled dvr?

So there are three scenarios:

new deployment: this doesn't matter, you will have to pick the value you want (I think default is false)
existing deployment that has a package which had the patch that gets reverted here: this doesn't matter, as the migration will not be run, so settings won't be changed
existing deployment that has a very old package: this will matter, and l2pop will be disabled

My understanding is that the third case doesn't exist anymore, hence it's safe to revert the hack.

tpatzig commented 7 years ago

just checked our prod and yes we have the hack installed 😄 , so should be safe to merge

matelakat commented 6 years ago

Re-basing it

matelakat commented 6 years ago

Let's see what CI has to say.

sap-oc / crowbar-openstack

Revert "PTF: enforce use_l2pop = true" #43