Rename high-drift query string to high_drift

sapcc / ntp_exporter

Prometheus exporter for NTP offset/stratum of a client

Apache License 2.0

50 stars 17 forks source link

Rename high-drift query string to high_drift #122

Closed SuperSandro2000 closed 2 months ago

SuperSandro2000 commented 2 months ago

Closes #112

Prometheus does not allow dashes in labels.

majewsky commented 2 months ago

Don't take this as disapproval, but I still do not understand where the issue is. This is a URL query parameter, not a label. Can someone explain?

Nuckal777 commented 2 months ago

@SuperSandro2000 mentioned to me, that url parameters specified in a prometheus scrape config are turned into labels. I haven't found a reference, yet. 🤷

stamatis-maritsas-sympower commented 2 months ago

that url parameters specified in a prometheus scrape config are turned into labels

Exactly that, and Prometheus doesn't like hyphens (data model reference).

Edit: After testing new version with fix it works as expected. Thanks for your efforts @Nuckal777 @SuperSandro2000 and @majewsky