search

saraedum / switchasitype

A firefox extension that automatically switches the dictionary used for spellchecking.
https://addons.mozilla.org/en-US/firefox/addon/260207/
MIT License
4 stars 0 forks source link

Cld #6

Open Archaeopteryx opened 9 years ago

saraedum commented 9 years ago

Thanks for implementing this! I'll try to have a more detailed look later today. Do you have a real name which I could mention in the Changelog? Should I use your github handle or should I not mention you at all?

saraedum commented 9 years ago

Btw. is there a standard about the tab width in javascript code? I agree that actual tabs are kind of silly. I might change the indent to four spaces though.

Archaeopteryx commented 9 years ago

Should I use your github handle or should I not mention you at all?

Please use my github nick.

Btw. is there a standard about the tab width in javascript code? I agree that actual tabs are kind of silly.

Mozilla's style guide calls developers to use 2 space indents, but there are at least files in the code which use 4.

saraedum commented 9 years ago

Trying with Firefox 35.0.1 your changes did not work. I installed a few dictionaries but it did not switch between them. I did not have time to debug the issue more thoroughly. Do you have any idea what could be the issue?

Archaeopteryx commented 9 years ago

What kind of dictionaries did you install for testing? The CLD library supports the languages listed here

I tested it in a profile with English, French, German, and Spanish dictionaries installed and opened https://pastebin.mozilla.org/ and typed sentences like "Ich bin ein Berliner" (German), "Je suis Parisien" (French) or "I am from London" - also sufficient to detect the language, and setting the dictionary also works. Do you see any related errors in the browser console?