search

sarmadhamdani02 / WebGames

This repo contains some web-based games, feel free to contribute 🙂 you can either create new games or contribute by solving issues.
https://webgames02.netlify.app/
9 stars 23 forks source link

Added themes to the Tic Tac Toe game #19

Closed SandipGyawali closed 1 year ago

SandipGyawali commented 1 year ago

11 (Issue)

Added three different themes to the game and each time the theme gets restarted the random theme will be setup in the game. @sarmadhamdani02

sarmadhamdani02 commented 1 year ago

I really loved all the themes, really nice work 👏👏

However, I personally think the border colors of the game-panel (class in HTML) and the text were better in white color 🤔 I think it is much better to leave them as they were. What do you think?

Apart from this everything is fantastic.

SandipGyawali commented 1 year ago

ok i will change it

SandipGyawali commented 1 year ago

@sarmadhamdani02 can you review my pull requestion now ?

sarmadhamdani02 commented 1 year ago

@SandipGyawali

I fixed the borders of the game-panel which is great 👏 but I was also talking about the text (O/X) in it.

image

SandipGyawali commented 1 year ago

oh ok will fix that

SandipGyawali commented 1 year ago

@sarmadhamdani02 check the project again

sarmadhamdani02 commented 1 year ago

@SandipGyawali

Now, that is awesome 👏

sarmadhamdani02 commented 1 year ago

Now, I am thinking about adding more themes. How about 10 in total? I will create a separate issue for that. If you will contribute to that it will be great. Otherwise, it will be a good "good first issue".

SandipGyawali commented 1 year ago

I think the themes that I created are enough in general. It would be great if we can work on other issues which make the learning process efficient by working on different challenges. Just iterating the theme for more variety doesn't make the learning more efficient in my opinion. Instead we can work on the different issue on the different repo where we get to exposure to many people as well as work on different stuffs

sarmadhamdani02 commented 1 year ago

Good point 💯 @SandipGyawali

Although I have created the issue, let it be solved by some other beginner. Let's see other problems 💪

SandipGyawali commented 1 year ago

Ok. Tell me if you find any similar kind of issue a bit challenging. I will be happy to contribute to it. And if I find any other extra issues I will reach out to you so we can both solve the issue and progress simultaneously.

sarmadhamdani02 commented 1 year ago

Sure! it will be great 👍

SandipGyawali commented 1 year ago

are there any issues that you are familiar with right now? If yes then let's contribute to it. I don't have any contribution to make right now.

sarmadhamdani02 commented 1 year ago

Right now, I don't have any issues in my mind. Most of the issues in the issues section have been assigned to someone.

People are taking more interest in removing bugs and fixing small issues but not in adding more games which makes sense because making a whole game is a bit bigger task. 🤔

Why don't you try making a game? I know it will be a bigger task but it will be quite helpful as right now we are having only two games 😅 (although I think fixing bugs in games is more important than adding a new one). So, how about try making some game, any type of game? You can make a clone game or get inspiration from classic games.

sarmadhamdani02 commented 1 year ago

are there any issues that you are familiar with right now? If yes then let's contribute to it. I don't have any contribution to make right now.

@SandipGyawali Some issues have been added, you can check them out.