Closed treblig-punisher closed 1 year ago
treblig-punisher
commented
1 year ago Hey Sarmad, I have submitted my fixes to the game. The game was getting soft locked because of an infinite loop, and also it wasn't changing themes on restart either. It was also allowing for multiple clicks on the same answers causing big issues. All of this is now resolved.
sarmadhamdani02
commented
1 year ago Excellent Job @treblig-punisher 👏
It was a lot of work, wasn't it? 😄 Just remove those Console.log(); messages, and once that's done, I'll be able to merge the pull request.
treblig-punisher
commented
1 year ago Excellent Job @treblig-punisher 👏
It was a lot of work, wasn't it? 😄 Just remove those Console.log(); messages, and once that's done, I'll be able to merge the pull request.
yeah, it was. I had to first find out how the game would know when it was over and what it was keeping track of. It looks like the changesI made didn't make it as I removed those logs. I'll get to it. Glad to be of help. I'll take a look at what other issues I can tackle as this was fun to fix.
treblig-punisher
commented
1 year ago Alright, all console.log lines should be completely removed now. Let me know
sarmadhamdani02
commented
1 year ago 👏
-Fixed an infinite loop caused by a recursion bug where the questions asked array didn't get emptied.
-Fixed a bug where the theme wouldn't get changed upon restarting the game after the game over screen.
-changed all comparisons using == to using === for true check rather than type coercion.