search

sarmadhamdani02 / WebGames

This repo contains some web-based games, feel free to contribute 🙂 you can either create new games or contribute by solving issues.
https://webgames02.netlify.app/
9 stars 23 forks source link

Change text from Dark mode to Light mode by clicking #84

Open ChaviSchatz opened 1 year ago

ChaviSchatz commented 1 year ago

Hi! In the meantime, I changed the Dark Mode button - which will change to Light Mode when pressed.

sarmadhamdani02 commented 1 year ago

Hi @ChaviSchatz 👋 Thanks for the PR.

If you are talking about the icon below, image

Then, it can be a good idea. But I think in this way we should increase the size of the icon a bit in order to make it a bit more appealing. 🤔

ChaviSchatz commented 1 year ago

Sorry I didn't consider mobile mode but only computer mode. I will work on it Thanks!

sarmadhamdani02 commented 1 year ago

I apologize, but I'm having trouble understanding the purpose of this PR. Could you please explain?

ChaviSchatz commented 1 year ago

Yes, sorry I wasn't clear. What I did is that when you click on Dark Mode, the screen goes dark. So instead of it now being written Dark Mode to make it bright I changed it to Light Mode which will become bright. I did it. Interested in it?

ChaviSchatz commented 1 year ago

Attached photos. You will understand more what I meant.

Dark Mode Light Mode

sarmadhamdani02 commented 1 year ago

Ok, thank you so much for the clarification. 😊 I will soon review the PR and will let you know if there is any change required.

sarmadhamdani02 commented 1 year ago

Hi there 👋 Just saw the latest changes made. I don't really think that changing that background and tic-tac-toe's thumbnail is really necessary. 🤔 What do you say?

ChaviSchatz commented 1 year ago

I thought it might add to the visibility of the page. But of course not necessary...